From 15b72591d4f3e70b70bc96cce6051d5568d7dd95 Mon Sep 17 00:00:00 2001
From: Matt Jankowski <matt@jankowski.online>
Date: Wed, 30 Jul 2025 05:48:18 -0400
Subject: [PATCH] Use attribute for `User#external?` (#35579)

---
 app/models/user.rb | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/app/models/user.rb b/app/models/user.rb
index 0c876c64b..2f3640b62 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -143,7 +143,9 @@ class User < ApplicationRecord
   delegate :can?, to: :role
 
   attr_reader :invite_code, :date_of_birth
-  attr_writer :external, :bypass_registration_checks, :current_account
+  attr_writer :bypass_registration_checks, :current_account
+
+  attribute :external, :boolean, default: false
 
   def self.those_who_can(*any_of_privileges)
     matching_role_ids = UserRole.that_can(*any_of_privileges).map(&:id)
@@ -507,10 +509,6 @@ class User < ApplicationRecord
     Setting.registrations_mode == 'open'
   end
 
-  def external?
-    !!@external
-  end
-
   def bypass_registration_checks?
     @bypass_registration_checks
   end